Formatting Your SQL Statement Correctly


I am trying to set up a recordset from the results of a form. On the ASP page, I have set a variable to the entry from the form but I want to enter this value in the search query, whatever it may be.

<% style= Request.Form("IPStyle") price = Request.Form("IPPrice")%><% IF price = "Cheap" THEN    Set RSFrames = Server.CreateObject("ADODB.Recordset")   strSql = "SELECT * FROM Frames WHERE Type = style  AND Cost < 10"    RSFrames.Open  strSQL, cn

This code works except I can only make the 'Type = style' search for the word "style" or I generate an error.


In your code, "style" is a variable that contains the value of whatever was present in the form control: "IPStyle". Within your SQL statement, you want this value to be placed, and not the name of the variable.

Therefore, change your SQL statement from:

strSql = "SELECT * FROM Frames WHERE Type = style  AND Cost < 10" 


strSql = "SELECT * FROM Frames WHERE Type = " & style & " AND Cost < 10" 

If the field named 'Type' is a character field (string), then you need to enclose the value of the "style" variable within quotes. So, change your SQL statement to:

strSql = "SELECT * FROM Frames WHERE Type = '" & style & "' AND Cost < 10" 

If there is a potential for the value of the "style" variable itself to have a single quote within it (for example, "Ladies' Jackets"), then you need to be extra careful. So change your code to take care of that issue first, by replacing all occurrences of the single quotes to two single quotes:

style = Replace(style, "'", "''")   strSql = "SELECT * FROM Frames WHERE Type = '" & style & "' AND Cost < 10" 

By the way, you should avoid using names like "style", and "price" for your variables. "Style" is a reserved word in HTML, and CSS (whether using JavaScript or VBScript). You will have trouble and will spend hours trying to figure out why your code is not working. Always use non-English-dictionary words for variable names. For example, simply change it to "strStyle".

Share the Post:
Share on facebook
Share on twitter
Share on linkedin


The Latest

homes in the real estate industry

Exploring the Latest Tech Trends Impacting the Real Estate Industry

The real estate industry is changing thanks to the newest technological advancements. These new developments — from blockchain and AI to virtual reality and 3D printing — are poised to change how we buy and sell homes. Real estate brokers, buyers, sellers, wholesale real estate professionals, fix and flippers, and beyond may

man on floor with data

DevX Quick Guide to Data Ingestion

One of the biggest trends of the 21st century is the massive surge in internet usage. With major innovations such as smart technology, social media, and online shopping sites, the internet has become an essential part of everyday life for a large portion of the population. Due to this internet

payment via phone

7 Ways Technology Has Changed Traditional Payments

In today’s digital world, technology has changed how we make payments. From contactless cards to mobile wallets, it’s now easier to pay for goods and services without carrying cash or using a checkbook. This article will look at seven of the most significant ways technology has transformed traditional payment methods.